feat: allow linuxstatic builds for ppc64 architecture #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added system information display and additional cleanup steps.
nrranjithnr
changed the title
|
@robertsLando, could you please take a look at this when you have a moment? Thanks! |
|
Succeeded Test build run: https://github.com/nrranjithnr/pkg-fetch/actions/runs/18187593970 |
robertsLando
changed the title
robertsLando
requested changes
Oct 3, 2025
|
|
||
| if (hostPlatform !== platform) { | ||
| if (hostPlatform !== 'alpine' || platform !== 'linuxstatic') { | ||
| if ((hostPlatform !== 'alpine' || platform !== 'linuxstatic') && arch !== 'ppc64') { |
There was a problem hiding this comment.
I'm wondering if this makes sense, I mean shouldn't you only be able to build ppc64 from a ppc64 arch?
There was a problem hiding this comment.
When I run the node24-linuxstatic-ppc64 build on a ppc64 machine, it doesn’t proceed because of this validation. I applied a patch to fix the code and tested it on a ppc64 machine — it worked for linuxstatic. So by default, it should work when running on a ppc64 machine; the only issue is that this validation is blocking it.
There was a problem hiding this comment.
[root@rh-rn-pvm test]# pkg --targets node24-linuxstatic-ppc64 --out-dir test/build .
> [email protected]
> Fetching base Node.js binaries to PKG_CACHE_PATH
fetched-v24.8.0-linuxstatic-ppc64 [ ] 0%
> Error! 404: Not Found
> Not found in remote cache:
{"tag":"v3.5","name":"node-v24.8.0-linuxstatic-ppc64"}
> Building base binary from source:
built-v24.8.0-linuxstatic-ppc64
> Error! Not able to build for 'linuxstatic' here, only for 'linux'
[root@rh-rn-pvm test]# uname -s
Linux
[root@rh-rn-pvm test]# uname -r
4.18.0-553.76.1.el8_10.ppc64le
[root@rh-rn-pvm test]#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow linuxstatic platform builds for ppc64 architecture by bypassing the platform validation check.
Changes
lib/index.tsto skip the platform mismatch check when building for ppc64 architecture&& arch !== 'ppc64'condition to allow linuxstatic builds on ppc64 without validation errorsImpact
Use Case
This enables building static Linux binaries on ppc64 systems, which is particularly useful for PowerPC environments that need statically linked executables.