Skip to content

Conversation

@manuelleduc
Copy link
Contributor

@manuelleduc manuelleduc commented Oct 30, 2025

…ingRights

Jira URL

https://jira.xwiki.org/browse/XWIKI-23647

Changes

Description

  • remove use of the deprecated DocumentAccessBridge#hasProgrammingRights;
  • move DocumentAccessBridge#hasProgrammingRights to legacy;
  • check if the import of the bridge module can be removed from some modules;
  • introduce xwiki-platform-legacy-bridge
  • update the import in packaging to use the new xwiki-platform-legacy-bridge module

Screenshots & Video

N/A

Executed Tests

mvn clean install -pl xwiki-platform-core,xwiki-platform-core/xwiki-platform-bridge,xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-script,xwiki-platform-core/xwiki-platform-legacy,xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore,xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer,xwiki-platform-core/xwiki-platform-oldcore,xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-script,xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-ui,xwiki-platform-distribution/xwiki-platform-distribution-war-legacydependencies -Pquality,legacy,distribution -amd

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • N/A

@manuelleduc manuelleduc marked this pull request as ready for review October 30, 2025 10:15
@manuelleduc manuelleduc requested a review from tmortagne October 30, 2025 10:17
@manuelleduc manuelleduc self-assigned this Oct 30, 2025
…ingRights

Introduction of xwiki-platform-legacy-bridge
…ingRights

Add dependencies to xwiki-platform-legacy-bridge on xwiki-platform-distribution-war-legacydependencies
vmassol and others added 5 commits October 30, 2025 14:15
…#3281)

* Added a translation to contain the warning for users.
* Added this warning
* Replaced the wiki syntax with HTML syntax for the creation of the DL. Note that now when there's no property, the DL is still generated, but I verified that it's invisible both visually and semantically
* Added wiki escaping before the HTML escaping since we support wiki syntax in this HTML macro now.
@manuelleduc manuelleduc requested a review from tmortagne October 30, 2025 13:52
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedmaven/​us.springett/​cvss-calculator@​1.4.38110089100100
Addedmaven/​org.webjars/​jstree@​3.3.16100100100100100

View full report

@manuelleduc manuelleduc merged commit a8a2557 into xwiki:master Oct 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants