XWIKI-22999: Activity stream should use list semantics #4715
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed a missing style (forgot it when moving things back from my test instance?) * Fixed the HTML5 validity test by wrapping the placeholder in a li
michitux
reviewed
Oct 28, 2025
| return computeAsyncPlaceholder(response, configuration.isCount()); | ||
| // We wrap the async placeholder in a listitem which makes it more consistent with the | ||
| // result of the macro. | ||
| return String.format("<li>%s</li>", computeAsyncPlaceholder(response, configuration.isCount())); |
There was a problem hiding this comment.
Are you sure this won't lead to nested <li> elements once the placeholder has been resolved?
There was a problem hiding this comment.
Thank you for the help! You're right, I updated the PR to avoid this issue in 032ae95 👍
Here is what the DOM looked like
And what it looks like now:
The async script uses the data contained on the placeholder to replace it:
I misread the method signature of computeAsyncPlaceholder and thought it was an API. But in fact it's just a private method and we should be free to update it and its result.
I tested this change manually on my local instance (see screenshot above).
* Changed the solution to avoid the placeholder replacement resulting in leftover DOM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22999
Changes
Description
Clarifications
Screenshots & Video
Before this PR:
After this PR:
Executed Tests
Built the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api.Tested
mvn clean install -f xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandardswith the HTML5 validator only. Somehow the tests failed on another page, for what seems like unrelated reasons. I could reproduce the errors before the changes and not anymore after the changes so it seems like it's an improvement. Note that I could not get-Dpatternto work on the build, and despite removing the other validators from my tests, it still took 35mins to run once...Expected merging strategy