Skip to content

Conversation

jameswartell
Copy link

@jameswartell jameswartell commented Jan 24, 2025

I was planning on making some other changes, but first I needed to adjust to be able to even build this.

There was an issue with the spoon plug-in where module enforcement prevented the build due to the need to access some std library functions. This need was removed in newer versions of the spoon plug-in.

There are rules that technical pages need to be hidden.

@jameswartell
Copy link
Author

err just noticed this in the pom

      <visibleTechnicalPages>
        <visibleTechnicalPage>.*/PublicationWorkflow/Overview\.xml</visibleTechnicalPage>
        <visibleTechnicalPage>.*/PublicationWorkflow/WebHome\.xml</visibleTechnicalPage>
      </visibleTechnicalPages>

Wonder why it isn't working.

@acotiuga
Copy link
Contributor

@jameswartell I don't think you need to do this changes to build this project. Maybe you could provide more details about the problem and even create a jira issue on https://jira.xwiki.org/projects/XAWORKFLOW.

@jameswartell
Copy link
Author

I found a bug in wiki-commons with the xar plug-in that is breaking the visibleTechnicalPages when building on Windows, so that is not necessary. The other change I believe is necessary. I'll add some details but first I'm going to deal with this XAR plug-in bug.

@jameswartell
Copy link
Author

This should fix the issue with the visible technical pages: xwiki/xwiki-commons#1220

This issue was due to a bug in the XAR plug-in. The changes are not
needed.
@jameswartell
Copy link
Author

The spoon issue I ran into was this one: INRIA/spoon#4251

Building with Java 17 (on Windows, but I don't think Windows is part of the issue in this case) fails without the update.

@jameswartell
Copy link
Author

Okay. I'm cancelling this. I think the spoon issue got fixed in the parent pom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants