Bridge #34
Merged
Bridge #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarrydGlucode
approved these changes
Dec 18, 2024
ryanbrear
reviewed
Oct 17, 2025
Comment on lines
+101
to
104
| protocol RenderableProductView { | ||
| func render() -> [ComponentView] | ||
| } | ||
| ``` |
There was a problem hiding this comment.
The original code included a number of properties in this protocol that leaked implementation details. Removed them and updated render to return the array of [ComponentView] as it's cleaner.
ryanbrear
reviewed
Oct 17, 2025
Comment on lines
115
to
139
| struct AppleWatchSummaryView: RenderableProductView { | ||
| private let product: Product | ||
| private let componentRenderer: ProductComponentRenderer | ||
|
|
||
| func render() -> [ComponentView] { | ||
| [ | ||
| componentRenderer.renderTitleView(for: product), | ||
| componentRenderer.renderPriceView(for: product), | ||
| componentRenderer.renderCarouselView(for: product) | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| class CreditCardPaymentProvider: PaymentProvider { | ||
| func processPayment(amount: Double) async -> Result<String, Error> { | ||
| return .success("Visa payment succeeded.") | ||
| struct AppleWatchTechSpecsView: RenderableProductView { | ||
| private let product: Product | ||
| private let componentRenderer: ProductComponentRenderer | ||
|
|
||
| func render() -> [ComponentView] { | ||
| [ | ||
| componentRenderer.renderTitleView(for: product), | ||
| componentRenderer.renderPriceView(for: product), | ||
| componentRenderer.renderTechSpecsView(for: product) | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
Changed these concretions to structs, removed redundant private(set), and redundant inits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.