Skip to content

WIP: Add sample app #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Add sample app #15

wants to merge 2 commits into from

Conversation

bryant1410
Copy link
Member

@bryant1410 bryant1410 commented Mar 16, 2018 •
edited by mirland
Loading

Fixes #7

  • SingleTypeRecyclerViewAdapter example
  • Empty view
  • Loading view
  • BaseRecyclerViewAdapter with multiple items
  • On demand page load

mirland
mirland reviewed Mar 16, 2018
View reviewed changes
sample/src/main/AndroidManifest.xml
/>
tools:ignore="AllowBackup">

<activity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single line

sample/src/main/res/layout/activity_main.xml
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now now, but maybe later

@bryant1410 bryant1410 requested a review from a team as a code owner March 23, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirland mirland mirland left review comments

@FerrariBruno FerrariBruno Awaiting requested review from FerrariBruno

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryant1410 @mirland