protobuf-cpp: Fixed on_test when compiling without tools.

[Slin]

When trying to use the protobuf-cpp package, the install step would fail for me because I disabled tools as part of my config. With this small fix, it will check in on_test if the tools have actually been enabled before trying to use protoc.

[gemini-code-assist]

Summary of Changes

Hello @Slin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a targeted fix for an installation issue within the protobuf-cpp package. Specifically, it addresses a scenario where the package's test suite (on_test) would attempt to utilize protoc even when the tools configuration was disabled, leading to build failures. The change introduces a conditional check to prevent this behavior, ensuring successful compilation and installation for users who opt to disable the tools component.

Highlights

• Fix for on_test failure: The pull request resolves an issue where the on_test function for protobuf-cpp would fail when the tools configuration was disabled during compilation.
• Conditional protoc usage: A check has been added to the on_test function to ensure that protoc is only invoked if the tools configuration is explicitly enabled, preventing errors in environments where tools are not present.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a failure in the on_test phase when compiling protobuf-cpp without the tools option. The approach of checking the tools configuration before running a test that depends on protoc is correct. However, the current implementation has inverted logic, causing the test to run only when tools are disabled, which will result in a failure. I've provided a comment with a suggested fix to correct this logical error.