cuda: support download toolchains #7459
Merged
+49
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Jun 21, 2025
|
|
||
| if package:is_plat("windows") then | ||
| local z7 = assert(find_tool("7z"), "7z tool not found!") | ||
| os.vrunv(z7.program, {"x", "-y", package:originfile()}) |
There was a problem hiding this comment.
尽管 xmake 内置了 7z，不过既然包里面用，还是走 add_deps + 直接调用会更好吧。毕竟也有不通过安装包，直接用的 xmake bundle ，那个是不带 7z 的
There was a problem hiding this comment.
测试了一下，目前就自动带上，不需要 add_deps
=> install 7z 19.00 .. ok
checking for 7z ... C:\Users\star\AppData\Local\.xmake\packages\7\7z\19.00\5d9443e8176e475d9915057113db5607\bin\7z.exeThere was a problem hiding this comment.
我知道，这就是我上面说的。如果用户用 xmake installer 安装的，会自带 7z ，走这里的 envs 就能自动找到。
但是也有用户会走 scoop, xmake zip 包，以及 bundle 包直接调用 xmake 命令。这几种情况下， xmake 是不会自带 7z 的。 如果不加 add_deps 是不会找到 7z 的。
There was a problem hiding this comment.
没理解，我这里测试就是模拟了没自带 7z 的
xmake f -c -v
checking for platform ... windows
checking for architecture ... x64
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\bin\HostX64\x64\cl.exe
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.44.35211
checking for nim ... no
checking for nim ... no
checking for git ... C:\Users\star\scoop\shims\git.exe
checking for gzip ... no
checking for 7z ... no
checking for 7za ... no
C:\Users\star\scoop\shims\git.exe rev-parse HEAD
checking for 7z ... no
checking for 7za ... no
checking for 7z ... no
checking for 7za ... no
note: install or modify (m) these packages (pass -y to skip confirm)?
in xmake-repo:
-> 7z 19.00 [host]
please input: y (y/n/m)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7179