This repository was archived by the owner on Aug 4, 2020. It is now read-only.
Adjusted current time with elapsed ticks #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atigyi
reviewed
Mar 6, 2018
| { | ||
| xi_bsp_time_sntp_init( NULL ); | ||
| if (xi_bsp_time_sntp_getseconds_posix() != 0) | ||
| { |
There was a problem hiding this comment.
Why is this condition necessary?
If the getseconds equals zero, then isn't it a failure? Failure during getting the time from SNTP server? Also means the HAL_GetTick() returns zero, right?
If time isn't received from SNTP service the connection to broker should fail anyway. So, I would stick to a simple:
ticks_at_start = HAL_GetTick(); without a condition.
|
Good catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is calculating in the elapsed ticks at the init time to remove the problematic offset.
Details:
The HAL tick counter is reflecting the elapsed time since the startup of the MCU. When the xi_bsp_time_init() is called the tick counter is already containing the elapsed time (it is non-zero). This distorts the result of the xi_bsp_time_getcurrenttime_seconds() function as a problematic offset will appear. This is even more significant in case the xi_bsp_time_init() is called repeatedly or with a delay.