Skip to content

Conversation

@nomis-c
Copy link
Collaborator

@nomis-c nomis-c commented Jul 28, 2025

No description provided.

@xin-huang
Copy link
Owner

please use https://github.com/snakemake/snakefmt to format Snakemake files

with:
directory: .test/ci/
snakefile: workflow/Snakefile
args: "--configfile config/main.yaml --use-conda --show-failed-logs -j 2 --dry-run --conda-frontend mamba"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the current test relies on a dry-run. To create more reliable and meaningful unit tests, please refer to https://snakemake.readthedocs.io/en/stable/snakefiles/testing.html

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dry-run tests should be retained.

@xin-huang
Copy link
Owner

@xin-huang
Copy link
Owner

Please revise the scripts in the scripts folder to accept parameters via Snakemake variables rather than command-line arguments.

@xin-huang
Copy link
Owner

https://snakemake.readthedocs.io/en/stable/snakefiles/best_practices.html

@xin-huang
Copy link
Owner

@xin-huang
Copy link
Owner

Please also fix the empty frequency spectrum generated from dadi

@xin-huang
Copy link
Owner

https://dockstore.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants