downloader: Support resuming from failed downloads #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case of timeouts etc
|
Hmm, is this safe? We usually don't check checksums of downloaded files, and it would be really bad if resumed downloads were corrupted by the process. Wouldn't re-downloading a bit better? Also, is there a way we could add a test for this? (Usually a bit harder with this kind of stuff...) |
|
Hmm good point, could validate the download with etag if the server supports and/or double check the file size lines up with Content-Length. w.r.t test could use the file:// protocol "downloading" it from path A to path B and break the "download", testing it resumes correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of timeouts etc