Skip to content

Conversation

konstntokas
Copy link
Contributor

@konstntokas konstntokas commented Aug 22, 2025

The endpoint_url was wrongly assigned to "http://localhost:8080/s3", which prevents data access. This Pr fixes this issue by parsing in the base url.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@konstntokas konstntokas changed the title Fix endpoint url is STAC item's asset published by xcube server Fix endpoint url in STAC item's asset published by xcube server Aug 22, 2025
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (7d05c11) to head (cdf3632).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1178   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         280      280           
  Lines       21659    21659           
=======================================
  Hits        19387    19387           
  Misses       2272     2272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@konstntokas konstntokas requested a review from forman October 8, 2025 08:11
@forman forman removed the request for review from AliceBalfanz October 8, 2025 08:26
@forman forman merged commit e4db208 into main Oct 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants