Skip to content

Conversation

clarasb
Copy link
Collaborator

@clarasb clarasb commented Aug 12, 2025

This PR:

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@clarasb clarasb requested a review from forman August 12, 2025 15:55
@clarasb clarasb changed the title add resolutions and spatialUnits to mldataset WebAPI: Add resolutions and spatialUnits to mldataset Aug 12, 2025
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine, but please write a CHANGELOG entry.

Although the code is covered by at least one test, none of them really asserts the correctness of the new settings. Consider writing a new unit test or enhancing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants