Skip to content

Conversation

@nathanael-h
Copy link
Member

Eliminate scripts that were committed in two repositories to maintain a single source of truth.

@glehmann glehmann requested a review from stormi October 9, 2025 07:32
@stormi
Copy link
Member

stormi commented Oct 14, 2025

Some scripts were commited in two repos, I removed them from this
one to have only one repo being single souce of thruth which is
an internal repo.
Signed-off-by: Nathanaël HANNEBERT <[email protected]>
@nathanael-h
Copy link
Member Author

  1. Commit msg fixed.
  2. The Ansible internal repo used to track the deployment of Koji

@stormi
Copy link
Member

stormi commented Oct 20, 2025

So we're moving public scripts to an internal repository? I'm not sure this is right.

@nathanael-h
Copy link
Member Author

I am not sure neither. The scripts are really specific for our infra needs, if someone else wants to build XCP-ng from sources I doubt the scripts would help in anything. Maybe it was not needed to have them in a public repo initially, but I have no strong opinion. I just want to fix the split brain.

@stormi
Copy link
Member

stormi commented Oct 20, 2025

Our policy is: public by default, unless it has to be private. Maybe it's OK to move these scripts to an internal repository, but I would have preferred not to discover it with a PR that removes them from what I still considered their main location. I wasn't even aware that they had been duplicated.

@glehmann
Copy link
Member

A PR is a proposition of change, that can be rejected or accepted.
Your opinion has been explicitly requested to give you a chance to agree or disagree before committing to anything.

What would be your preferred way to propose a change?

@stormi
Copy link
Member

stormi commented Oct 24, 2025

A PR is a proposition of change, that can be rejected or accepted.

I already expressed myself about this. A draft is a proposition. A PR is saying "this is the right solution to me, please merge unless you have strong concerns about it". For the reviewer, that's not the same thing.

Here you're asking me to put my stamp on an already made move. That's not what I call a proposition. In some contexts, it's good enough. Here I had a need for a bit more context, and maybe even a quick talk about the move, that's all :)

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now have all the information I need about the internal repo, how the files will be managed on it, and since the move is already done and I have no strong enough reason to block it, approving.

@stormi stormi merged commit 79cbd8c into master Oct 24, 2025
1 check passed
@stormi stormi deleted the move-scripts branch October 24, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants