-
Notifications
You must be signed in to change notification settings - Fork 89
Remove duplicated scripts #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d58ceb0 to
b55c7ed
Compare
|
Some scripts were commited in two repos, I removed them from this one to have only one repo being single souce of thruth which is an internal repo. Signed-off-by: Nathanaël HANNEBERT <[email protected]>
b55c7ed to
63d60f3
Compare
|
|
So we're moving public scripts to an internal repository? I'm not sure this is right. |
|
I am not sure neither. The scripts are really specific for our infra needs, if someone else wants to build XCP-ng from sources I doubt the scripts would help in anything. Maybe it was not needed to have them in a public repo initially, but I have no strong opinion. I just want to fix the split brain. |
|
Our policy is: public by default, unless it has to be private. Maybe it's OK to move these scripts to an internal repository, but I would have preferred not to discover it with a PR that removes them from what I still considered their main location. I wasn't even aware that they had been duplicated. |
|
A PR is a proposition of change, that can be rejected or accepted. What would be your preferred way to propose a change? |
I already expressed myself about this. A draft is a proposition. A PR is saying "this is the right solution to me, please merge unless you have strong concerns about it". For the reviewer, that's not the same thing. Here you're asking me to put my stamp on an already made move. That's not what I call a proposition. In some contexts, it's good enough. Here I had a need for a bit more context, and maybe even a quick talk about the move, that's all :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now have all the information I need about the internal repo, how the files will be managed on it, and since the move is already done and I have no strong enough reason to block it, approving.
Eliminate scripts that were committed in two repositories to maintain a single source of truth.