refactor: cleanup esm #1950
Open
refactor: cleanup esm #1950
+4,114
−3,489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
wxt-dev#1863) Co-authored-by: Aaron <[email protected]>
… CSS preprocessor (wxt-dev#1590) Co-authored-by: Aaron <[email protected]>
…dom` and `happy-dom` (wxt-dev#1844) Co-authored-by: Aaron <[email protected]>
I think this could be breaking in theory, but... - If you're using the default setup, you're already good. - If you've customized your Vite version, you probably thought it was a peer.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
As far as I could tell, the original reasons are no longer reproducible.
Since wxt-dev#848, there's no need to do all this async work. At least, as far as I could tell...
lishaduck
force-pushed
the
cleanup-esm
branch
from
ea11b14 to
8558aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A few tiny cleanups I noticed could be made while perusing around the codebase.
Manual Testing
Bundle, check it still works.
Related Issue
This PR is stacked on #1945.