-
Notifications
You must be signed in to change notification settings - Fork 533
Fixes Ogl when resizing and dragging shapes #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hasii2011
wants to merge
3
commits into
wxWidgets:master
Choose a base branch
from
hasii2011:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Float issues] [(s)]
[ * Attachment points are computed as float ] [wxWidgets#2739]
[ * Don't use RealPoint * Do integer arithmetic ] [(s)]
Want to get these set of changes into a daily build. If I need more patches I can work against it. I verified these changes by modifying the virtual environment I created. |
Can you either edit the title or explain what that markup in the commit message and the PR title means? |
I hope the above is clearer. Please advise |
Couple things for the reviewers to watch for:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[
Many of the computations when resizing or moving OGL shapes result in float values. The result is that the
wx.DC
primitive calls fail because they expect integer values. This PR changes the computations results to become integer values, thus method calls on the wx device contexts do not failMost of the changes involve
//
' instead of the float operator '/
'wx.RealPoint
to justwx.Point
float
constants to integer constants]
Fixes #2739