Skip to content

Conversation

xerial-bot
Copy link
Collaborator

About this PR

πŸ“¦ Updates

from 2.18.4 to 2.20.0

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.fasterxml.jackson.datatype" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.fasterxml.jackson.datatype" }
}]
labels: library-update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine dependency update, upgrading two key Jackson datatype libraries: jackson-datatype-jdk8 and jackson-datatype-json-org. Both libraries have been updated from version 2.18.4 to 2.20.0. This update ensures the project utilizes the latest compatible versions of these essential JSON processing components, potentially bringing performance improvements, bug fixes, and new features from the updated library versions.

Highlights

  • Dependency Update: The jackson-datatype-jdk8 library, which provides support for Java 8 date/time and Optional types, has been upgraded from version 2.18.4 to 2.20.0.
  • Dependency Update: The jackson-datatype-json-org library, which provides support for org.json types, has been upgraded from version 2.18.4 to 2.20.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Scala Steward, updates two Jackson datatype dependencies from version 2.18.4 to 2.20.0. My review identifies a critical issue: the specified versions (2.18.4 and 2.20.0) do not appear to be available in public Maven repositories, which would cause the build to fail. I have suggested correcting the version to the latest available one, 2.17.2.

Comment on lines +967 to +968
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.20.0" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.20.0" % Provided,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The updated Jackson dependency version 2.20.0 does not appear to exist in public Maven repositories. This will likely cause a build failure due to dependency resolution errors. The previous version 2.18.4 also seems to be unavailable.

The latest published version for these artifacts (jackson-datatype-json-org and jackson-datatype-jdk8) is 2.17.2.

Please verify the correct version numbers. If the intent was to update to the latest, you should use 2.17.2.

For better maintainability, you could also define this version as a variable and reuse it for both dependencies.

        "com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.17.2" % Provided,
        "com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8"     % "2.17.2" % Provided,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant