Handle request object data clean if internal token clean up is enabled #2897
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the token update success tracking logic in the invalidateAndCreateNewAccessToken method by removing the tokenUpdateSuccessful variable and replacing its condition with isTokenCleanupFeatureEnabled.
- Removes unnecessary
tokenUpdateSuccessfulboolean variable and its assignment - Changes the post-refresh token event condition to depend on
isTokenCleanupFeatureEnabledinstead of update success status
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| IdentityDatabaseUtil.closeConnection(connection); | ||
| } | ||
| if (tokenUpdateSuccessful) { | ||
| if (isTokenCleanupFeatureEnabled) { |
There was a problem hiding this comment.
The condition has changed from checking if the token update was successful to checking if cleanup is enabled. This could cause post-refresh events to fire even when the database transaction failed and was rolled back, leading to inconsistent state.
Copilot uses AI. Check for mistakes.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2897 +/- ##
==========================================
Coverage 57.80% 57.81%
+ Complexity 9034 8996 -38
==========================================
Files 669 669
Lines 50275 50168 -107
Branches 10990 10974 -16
==========================================
- Hits 29062 29005 -57
+ Misses 17172 17129 -43
+ Partials 4041 4034 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Proposed changes in this pull request
$subject