Skip to content

Conversation

deshankoswatte
Copy link
Member

@deshankoswatte deshankoswatte commented Aug 21, 2025

Proposed changes in this pull request

  • Introduced a new configuration property OAuth.UseAbsolutePublicURLForAuthRequest to control whether the commonAuthCallerPath is built using the absolute public URL or the relative internal URL.
  • Updated EndpointUtil to use ServiceURLBuilder and select between getAbsolutePublicURL() and getRelativeInternalURL() based on the config.
  • This allows deployments that require the absolute public URL in the authorize request flow to work correctly.
  • The configuration is as follows:
[oauth]
use_absolute_public_url_for_auth_request = false

Fixes: wso2/product-is#22673, wso2/product-is#25357.

When should this PR be merged

N/A

Follow up actions

N/A

Developer Checklist (Mandatory)

  • Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly?

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

  • Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • Are all UI and API inputs run through forms or serializers?
  • Are all external inputs validated and sanitized appropriately?
  • Does all branching logic have a default case?
  • Does this solution handle outliers and edge cases gracefully?
  • Are all external communications secured and restricted to SSL?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.72%. Comparing base (3382285) to head (b10856f).
⚠️ Report is 202 commits behind head on master.

Files with missing lines Patch % Lines
...bon/identity/oauth/endpoint/util/EndpointUtil.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2870      +/-   ##
============================================
- Coverage     57.72%   57.72%   -0.01%     
+ Complexity     8989     8970      -19     
============================================
  Files           668      668              
  Lines         50067    50070       +3     
  Branches      10854    10855       +1     
============================================
+ Hits          28901    28902       +1     
+ Misses        17152    17151       -1     
- Partials       4014     4017       +3     
Flag Coverage Δ
unit 40.09% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proxy_context_path does not work as expected in authorize request

1 participant