Skip to content

Make software statement optional for DCR #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Make software statement optional for DCR #2813

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ff0986
Make software statement optional for DCR
pavinduLakshan Jun 11, 2025
ef8da16
Merge branch 'master' into fix_dcr
pavinduLakshan Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ....dcr/src/main/java/org/wso2/carbon/identity/oauth/dcr/DCRConfigurationMgtServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,7 @@ private Map<String, String> getAttributeMap(List<Attribute> attributes) {

private void validateMandateSSA (DCRConfiguration dcrConfiguration) throws DCRMClientException {

if (Boolean.FALSE.equals(dcrConfiguration.getAuthenticationRequired()) &&
!Boolean.TRUE.equals(dcrConfiguration.getMandateSSA())) {
// if authenticationRequired is False, mandateSSA should be True.
throw handleClientException(DCRMConstants.DCRConfigErrorMessage.ERROR_CODE_SSA_NOT_MANDATED);
} else if (Boolean.TRUE.equals(dcrConfiguration.getMandateSSA()) &&
if (Boolean.TRUE.equals(dcrConfiguration.getMandateSSA()) &&
StringUtils.isBlank(dcrConfiguration.getSsaJwks())) {
// if mandateSSA is True, ssaJwks should be provided.
throw handleClientException(DCRMConstants.DCRConfigErrorMessage.ERROR_CODE_SSA_JWKS_REQUIRED);
Expand Down