Skip to content

Fix ignored_paths matching to prevent false positives on substring matches #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix ignored_paths matching to prevent false positives on substring matches #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9022175
Initial plan
Copilot Nov 1, 2025
dd22d61
Fix ignored_paths false positives by matching at directory boundaries
Copilot Nov 1, 2025
f28365b
Improve path matching with regex for better robustness
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions features/find.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,44 @@ Feature: Find WordPress installs on the filesystem
"""
1
"""

Scenario: Directories with ignored path as substring should not be ignored
Given a WP install in 'wpblogs'
And a WP install in 'myjs'
And a WP install in 'logs'
And a WP install in 'js'

When I run `wp eval --skip-wordpress 'echo realpath( getenv( "RUN_DIR" ) );'`
Then save STDOUT as {TEST_DIR}

When I run `wp find {TEST_DIR} --field=version_path --verbose`
Then STDOUT should contain:
"""
Found WordPress installation at '{TEST_DIR}/wpblogs/wp-includes/version.php'
"""
And STDOUT should contain:
"""
Found WordPress installation at '{TEST_DIR}/myjs/wp-includes/version.php'
"""
And STDOUT should not contain:
"""
Found WordPress installation at '{TEST_DIR}/logs/wp-includes/version.php'
"""
And STDOUT should not contain:
"""
Found WordPress installation at '{TEST_DIR}/js/wp-includes/version.php'
"""
And STDOUT should contain:
"""
Matched ignored path. Skipping recursion into '{TEST_DIR}/logs/'
"""
And STDOUT should contain:
"""
Matched ignored path. Skipping recursion into '{TEST_DIR}/js/'
"""

When I run `wp find {TEST_DIR} --format=count`
Then STDOUT should be:
"""
2
"""
3 changes: 2 additions & 1 deletion src/Find_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,8 @@ private function recurse_directory( $path ) {
return;
}
foreach ( $this->ignored_paths as $ignored_path ) {
if ( false !== stripos( $compared_path, $ignored_path ) ) {
// Match at directory boundaries using regex to ensure we match complete directory names
if ( preg_match( '#(^|/)' . preg_quote( $ignored_path, '#' ) . '#i', $compared_path ) ) {
$this->log( "Matched ignored path. Skipping recursion into '{$path}'" );
return;
}
Expand Down
Loading