Use the same key for the Reader build step across pipelines
#24488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27464 | |
| Version | PR #24488 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f4c576c | |
| Installation URL | 7384himhq5j9o |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27464 | |
| Version | PR #24488 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f4c576c | |
| Installation URL | 17h17sdoeprm0 |
See how https://buildkite.com/automattic/wordpress-ios/builds/27417/steps?jid=01964b59-300d-46d2-bf40-33558caa03fa failed because the pipeline used `reader_asc_build` instead of `build_asc_reader`. I decided to consolidate to `build_asc_reader` because of the information hierarchy: build > build for ASC > build for ASC, the Reader app. When we'll get to split build from upload for the other apps, we'll be able to have auto-complete friendly keys, su as `build_asc_wordpress` or `build_firebase_jetpack`.
mokagio
force-pushed
the
mokagio/reader-step-name-consistency
branch
from
f9a8582 to
f4c576c
Compare
|
crazytonyli
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See how
https://buildkite.com/automattic/wordpress-ios/builds/27417/steps?jid=01964b59-300d-46d2-bf40-33558caa03fa failed because the pipeline used
reader_asc_buildinstead ofbuild_asc_reader. Thanks @twstokes for bringing this to my attention!I decided to consolidate to
build_asc_readerbecause of the information hierarchy: build > build for ASC > build for ASC, the Reader app.When we'll get to split build from upload for the other apps, we'll be able to have auto-complete friendly keys, su as
build_asc_wordpressorbuild_firebase_jetpack.Part of https://linear.app/a8c/project/automate-reader-ios-testflight-distribution-81ddc60737f0
Testing instructions
Run https://buildkite.com/automattic/wordpress-ios/builds/27449 to test this, which shows we need to wait for #24478 to land first.