Update Reader's secrets and add bare bone entitlements #24471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not much to see in the diff, by design! Safe to say that some of the `ApiCredentials` values have been updated and now point to dedicated Reader instances.
Generated by 🚫 Danger |
|
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27406 | |
| Version | PR #24471 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | af75531 | |
| Installation URL | 5mar07u6dqj2o |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27406 | |
| Version | PR #24471 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | af75531 | |
| Installation URL | 23j7kl4st5df0 |
mokagio
commented
Apr 17, 2025
| <string>group.org.wordpress</string> | ||
| </array> | ||
| </dict> | ||
| </plist> |
There was a problem hiding this comment.
No keychain access yet, see paaHJt-8hM-p2
crazytonyli
reviewed
Apr 21, 2025
| <array> | ||
| <string>webcredentials:wordpress.com</string> | ||
| <string>webcredentials:*.wordpress.com</string> | ||
| <string>applinks:links.wp.a8cmail.com</string> |
There was a problem hiding this comment.
This link appears to be used to open links in marketing emails. Maybe we should not fight with the WordPress and Jetpack apps to open those links?
There was a problem hiding this comment.
BTW, we probably do not need this link in all apps. I have asked the question here: pbMoDN-fd-p2#comment-7311
There was a problem hiding this comment.
Followed up in #24487
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says in the title.
Part of https://linear.app/a8c/issue/CMM-260/configure-reader-target