Skip to content

DRY notifications stack storyboard and initial VC access #24464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Apr 16, 2025

Follow us on the change in #24463 that fixed the notifications Storyboard access from the Reader app.

Screenshot 2025-04-16 at 1 46 29 PM Screenshot 2025-04-16 at 1 59 03 PM Screenshot 2025-04-16 at 1 58 31 PM

Part of https://linear.app/a8c/issue/CMM-260/configure-reader-target

@mokagio mokagio requested review from crazytonyli and kean and removed request for crazytonyli April 16, 2025 03:59
@mokagio mokagio marked this pull request as ready for review April 16, 2025 04:00
@mokagio mokagio added this to the 25.9 milestone Apr 16, 2025
@mokagio mokagio requested a review from crazytonyli April 16, 2025 04:00
@mokagio mokagio changed the base branch from trunk to mokagio/reader-secrets April 16, 2025 04:00
Base automatically changed from mokagio/reader-secrets to trunk April 16, 2025 11:30
@kean kean force-pushed the mokagio/refactor-notifications-storyboard branch from f57769e to 0f2e1dc Compare April 16, 2025 14:20
@kean kean enabled auto-merge April 16, 2025 14:20
@kean
Copy link
Contributor

kean commented Apr 16, 2025

Rebasing and merging 🙇

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27377
VersionPR #24464
Bundle IDorg.wordpress.alpha
Commit0f2e1dc
Installation URL4b9i0jhvivqoo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27377
VersionPR #24464
Bundle IDcom.jetpack.alpha
Commit0f2e1dc
Installation URL50r5ilo7acsm0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean added this pull request to the merge queue Apr 16, 2025
Merged via the queue into trunk with commit 6398075 Apr 16, 2025
31 of 33 checks passed
@kean kean deleted the mokagio/refactor-notifications-storyboard branch April 16, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants