Skip to content

Make Test Data a folder reference #24453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Make Test Data a folder reference #24453

merged 1 commit into from
Apr 15, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 14, 2025

This PR starts preparing WordPressTests for move to Tests/KeystoneTests. It contains only one change: add "Test Data" as a folder reference.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Apr 14, 2025
@kean kean added this to the 25.9 milestone Apr 14, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean requested a review from mokagio April 14, 2025 18:42
@kean kean enabled auto-merge April 14, 2025 18:42
@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27319
VersionPR #24453
Bundle IDcom.jetpack.alpha
Commit2ac5943
Installation URL386dg1ian8g0o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27319
VersionPR #24453
Bundle IDorg.wordpress.alpha
Commit2ac5943
Installation URL6fjsmbn349b8g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Before After
image image

Two non blocking nitpicks:

  • What do you think of removing the space in the folder name to be more scripts-friendly? From "Test Data" to "TestData"/"Test-Data" or even just "Data" or "Inputs"
  • Do we need the "Dashboard" subfolder? I mean it's handy to group those four files in there, but it makes the setup inconsistent. If we have "Dashboard", then we should also have "Activity-Log", "App-Review-Prompt".

@kean kean added this pull request to the merge queue Apr 15, 2025
Merged via the queue into trunk with commit dbb0750 Apr 15, 2025
35 checks passed
@kean kean deleted the task/prepare-test-target branch April 15, 2025 06:04
@kean
Copy link
Contributor Author

kean commented Apr 15, 2025

What do you think of removing the space in the folder name to be more scripts-friendly?

I'll update the folder structure in the upcoming PR when I move the files to Tests/KeystoneTests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants