Add keys to localized strings in AuthTokenIssueSolver.swift
#24401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27118 | |
| Version | PR #24401 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 741418c | |
| Installation URL | 1b68fb8lk8440 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27118 | |
| Version | PR #24401 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 741418c | |
| Installation URL | 3uo42q95jvn90 |
kean
reviewed
Apr 3, 2025
| let title = NSLocalizedString("Careful!", comment: "Title for the warning shown to the user when he refuses to re-login when the authToken is missing.") | ||
| let message = NSLocalizedString("Proceeding will remove all WordPress.com data from this device, and delete any locally saved drafts. You will not lose anything already saved to your WordPress.com blog(s).", comment: "Message for the warning shown to the user when he refuses to re-login when the authToken is missing.") | ||
| let title = NSLocalizedString( | ||
| "auth_token_issue_solver.cancel_alert.title", |
There was a problem hiding this comment.
Hey, thanks for updating it! Ideally, I would suggest moving these under private enum Strings - this is what we typically do. And it should used camel case.
mokagio
force-pushed
the
mokagio/auth-token-solver-localization-keys
branch
from
3f8a613 to
741418c
Compare
kean
approved these changes
Apr 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #24397. Nothing to test.