Add placeholder step in CI for Reader unit tests #24387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I named it with `..._app_store_reader` instead of `..._reader_app_store` like the other lanes for Jetpack and WordPress because I find that suffixing the app name leads to better code completion and homogeneous API. ``` ..._app_store_jetpack ..._app_store_reader ..._app_store_wordpress ``` This is not the time to change the other lane names, however.
mokagio
commented
Apr 1, 2025
| app_identifiers: ALL_READER_BUNDLE_IDENTIFIERS, | ||
| readonly: readonly | ||
| ) | ||
| end |
There was a problem hiding this comment.
I named it with ..._app_store_reader instead of ..._reader_app_store
like the other lanes for Jetpack and WordPress because I find that
suffixing the app name leads to better code completion and homogeneous
API.
..._app_store_jetpack
..._app_store_reader
..._app_store_wordpress
This is not the time to change the other lane names, however.
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27017 | |
| Version | PR #24387 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c93bbd7 | |
| Installation URL | 21h9pvddo1890 |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27017 | |
| Version | PR #24387 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c93bbd7 | |
| Installation URL | 0drrbehhv7nhg |
AliSoftware
approved these changes
Apr 1, 2025
| @@ -0,0 +1,12 @@ | |||
| #!/bin/bash -eu | |||
|
|
|||
| # Run this at the start to fail early if value not available | |||
There was a problem hiding this comment.
I'm not sure that would actually fail early if value not available, because despite this script having -eu in the shebang, if that script is source'd then the shebang is ignored…
If you really want such behavior you might want to extract the -eu from the shebang into dedicated set instructions instead
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only runs code signing sync to validate that bit of the process, see code comments.
There's a lot to discuss regarding infra and release process, but we don't have to have a plan for that to add a walking skeleton.