elm-review rule to fix version mismatch
#188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-murphy
commented
Mar 26, 2025
| "elm-review": "2.11.1", | ||
| "elm-review": "2.12.0", |
There was a problem hiding this comment.
From what I can tell, >= 2.12 of the elm-review CLI is needed for "analyzing arbitrary files" (so using withExtraFilesProjectVisitor) https://github.com/jfmengels/node-elm-review/releases/tag/v2.12.0
I tried 2.13 version of the CLI, but that seemed to require >= 2.15 of the library, so I just opted for the minimal upgrade to support the changes here.
pete-murphy
commented
Mar 27, 2025
pete-murphy
force-pushed
the
pete/117-elm-review-rule-for-version-match
branch
from
59e63a3 to
f94228d
Compare
So the version reported in the CLI output matches what's in `package.json`
pete-murphy
force-pushed
the
pete/117-elm-review-rule-for-version-match
branch
from
f94228d to
7d2de42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #117, fixes #148