Implement Postgres interpreter for ConversationStore #4764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
conversation-postgres
branch
2 times, most recently
from
9b41958 to
3f46a4d
Compare
akshaymankar
changed the title
akshaymankar
force-pushed
the
conversation-postgres
branch
9 times, most recently
from
a43b52a to
27e6e87
Compare
This will allow us to migrate rest of the conversation data to postgres
It has nothing to do with the store, the one place which calls this can call `Random.uuid` instead.
…e the Casssadnra interpreter
It was used only twice seems like unnecesary leak of business logic into the store effect.
Its unused, also seems dangerous to load **all** local members in memory
…rom db more general
…timestamptz The access_role column is not used anymore, so we can just dervie the value of access_roles_v2 from it and persist that. The timestamptz type maps to UTCTime, which we use everywhere, so this is more convenient.
akshaymankar
force-pushed
the
conversation-postgres
branch
from
53b1c71 to
648ce9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-19086
Checklist
changelog.d