WPB-18191: Add route to collaborator permissions from team #4697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackheaven
changed the base branch from
develop
to
gdifolco/WPB-18190_collaborator-delete-endpoint
zebot
added
the
ok-to-test
blackheaven
commented
Jul 31, 2025
| guardPermission (tUnqualified zUser) team TeamMember.UpdateTeamCollaborator InsufficientRights | ||
| Store.updateTeamCollaborator user team perms | ||
| unless (Set.member ImplicitConnection perms) $ | ||
| -- TODO gdf remove O2O conversations |
There was a problem hiding this comment.
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
2 times, most recently
from
689dd19 to
252bc04
Compare
blackheaven
changed the title
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
252bc04 to
ae16812
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
8e873f3 to
78aea4e
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
ae16812 to
a2cfeab
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
a2cfeab to
a423074
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
83eb7a1 to
c1f5acf
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
4fa59cc to
7a2e3ff
Compare
|
I cannot reproduce the error, which seems not related to my changes. |
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
c1f5acf to
0969d6d
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
7a2e3ff to
607cfcf
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
c5e0a60 to
30c92d0
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
607cfcf to
7d0a8c3
Compare
|
Does not seem related
|
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
32ad69b to
3160115
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
2 times, most recently
from
8d1a9b6 to
aa0dcda
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
2 times, most recently
from
5eb2959 to
c510050
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
aa0dcda to
280606b
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
741ffd8 to
0ec3937
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
3252544 to
9bc5ec3
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
9bc5ec3 to
13f60b0
Compare
blackheaven
force-pushed
the
gdifolco/WPB-18191_collaborator-update-endpoint
branch
from
bea7d22 to
f114414
Compare
fisx
reviewed
Sep 12, 2025
integration/test/API/Brig.hs
Outdated
| updateTeamCollaborator :: (MakesValue owner, MakesValue collaborator, HasCallStack) => owner -> String -> collaborator -> [String] -> App Response | ||
| updateTeamCollaborator owner tid collaborator permissions = do | ||
| (_, collabId) <- objQid collaborator | ||
| req <- baseRequest owner Brig Versioned $ joinHttpPath ["teams", tid, "collaborators", collabId] |
There was a problem hiding this comment.
Suggested change
| req <- baseRequest owner Brig Versioned $ joinHttpPath ["teams", tid, "collaborators", collabId] | |
| req <- baseRequest owner Galley Versioned $ joinHttpPath ["teams", tid, "collaborators", collabId] |
also move to another module.
| @@ -260,3 +260,33 @@ testRemoveMemberInTeamConversation = do | |||
| resp.status `shouldMatchInt` 200 | |||
| otherMembers <- asList (resp.json %. "members.others") | |||
| traverse (%. "qualified_id") otherMembers `shouldMatchSet` traverse (%. "qualified_id") [owner, alice] | |||
|
|
|||
| testUpdateMember :: (HasCallStack) => App () | |||
| testUpdateMember = do | |||
There was a problem hiding this comment.
Suggested change
| testUpdateMember = do | |
| testUpdateCollaborator = do |
blackheaven
force-pushed
the
gdifolco/WPB-18190_collaborator-delete-endpoint
branch
from
f7bee64 to
1c458bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-18191
Checklist
changelog.d