Add rb-fsevent support #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is in conflict with my #85 I personally prefere doing it the platform (and gem) agnostic way but I'm open to suggestions. |
|
@mschae If there's a better way to do it that's totally fine with me. I'll close this out so we can focus. |
|
@phallstrom Thanks. Winton is taking a look at my PR right now. I am fairly sure that using listen will adress your suggestion as well, it uses rb-fsevent on Darwin systems internally: https://github.com/guard/listen/blob/master/listen.gemspec#L18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to use rb-fsevent gem if it's installed. This will use OSX's fileevent API so stasis (via directorywatcher) doesn't have to poll the file system.