implemented with_entry, compute and compute_if_absent
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willothy
requested changes
May 27, 2025
| /// assert_eq!(map.contains_key(&"foo").await, false); | ||
| /// }); | ||
| /// ``` | ||
| pub async fn with_entry<R>(&self, key: K, f: impl FnOnce(K, Entry<(K, V)>) -> R) -> R { |
There was a problem hiding this comment.
I like the idea of with_entry but I do think it should take an async function (impl Fn(A) -> impl Future<Output = R>) instead of a normal closure.
|
And I do think we could potentially get an entry API with a bit of unsafe - will look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #15
I don't think we can get a proper
.entry(key)function with how the shards and locks are done, but this.with_entry(key, |key, entry| {})api should be enough for most use-cases.Also added functions
computeandcompute_if_absentthat are basically just wrappers aroundwith_entryto make it easier / more convenient to use, if you think that these don't belong in here, we can remove it, aswith_entrywill already be enough to get the job done.