[WFLY-18768] OpenShift support for the mail quickstart

[Dkafetzis]

https://issues.redhat.com/browse/WFLY-18768

[openshift-ci]

Hi @Dkafetzis. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[emmartins]

hi @Dkafetzis , I am delegating review to @yersan , who leads mail's component

[yersan]

/ok-to-test

[yersan]

Hello @Dkafetzis , you did great work with this, thanks!

I've added minor notes to review, also, when I compile the mail server locally, the readme.html generated does not contain all the steps related to helm charts and OpenShift, what is the trick to read the final documentation generated from this soruces?

[Dkafetzis]

@yersan Applied the suggested changes. Also fixed the Readme, it should now generate correctly.

[emmartins]

The changes looks good to me. If CI testing is green and @yersan approves too I will merge it.

[emmartins]

Please note that Kubernetes support will be needed to overcome the CI fail, but this can be done in a separated JIRA and PR. In case you want to do it here and now please let me know so I point you in the right direction.

[Dkafetzis]

@emmartins I'd like to also add support for kubernetes on the quickstart but In another issue since this is not part of Openshift and this one has been open for a long time.

[emmartins]

@Dkafetzis FYI not forgotten, just waiting for additional @kstekovi review, who will later add some testing changes on top of your work, this may take a week or more

[emmartins]

hi @Dkafetzis, I was trying your branch with Openshift sandbox, to finally merge this PR, but there is a major issue, there are no README instructions wrt the greenmail Helm Chart install. This should be done similar to how microprofile-reactive-messaging-kafka extends its README-source.adoc ( by adding an extra adoc file and pointing an attr to it, please see

quickstart/microprofile-reactive-messaging-kafka/README-source.adoc

Line 10 in f242714

:helm-install-prerequisites-openshift: ../microprofile-reactive-messaging-kafka/helm-install-prerequisites-openshift.adoc

)

Unfortunately I was not able to just use the traditional command we use for extras, which would be "oc apply -f ./charts/greenmail-openshift.yaml --wait --timeout=10m0s", and succeed with the standard openshift test command "$ mvn verify -Pintegration-testing -Dserver.host=https://$(oc get route mail --template='{{ .spec.host }}')"

I know this one has not been easy to make everyone happy, but in this case we really need fully working OpenShift instructions.

[Dkafetzis]

@emmartins I have added the needed reference to the RADME-source.adoc and renamed the file with the instructions on how to deploy greenmail on openshift to make it more clear. Also there was an error in one of the 2 integration tests that I hadn't noticed back then when I filed the PR. Finally and I don't know if this is mitigated when the automated testsuite is ran, but currently the helm file for the quickstart mentions this repository:

build: uri: https://github.com/wildfly/quickstart.git ref: main

Because of this though, the old jboss cli script of the mail quickstart is used resulting in the wildfly instance on openshift being unable to connect to greenmail on openshift. Changing temporarily the url and ref to my fork and this branch like so:

build: uri: https://github.com/Dkafetzis/quickstart.git ref: WFLY-18768 contextDir: mail deploy: replicas: 1 env: - name: MAIL_SERVER_ADDRESS value: greenmail

results in the correct jboss-cli script being downloaded and the tests working as expected. Obviously, once this pr is merged this will not be an issue anymore since the cli script on the main branch will get updated to the correct one.

[emmartins]

Thanks @Dkafetzis, I will check it as soon as possible.