Skip to content

refactor!: streamline and improve applayout api #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
Choose a base branch
from
Open

refactor!: streamline and improve applayout api #657

wants to merge 3 commits into from
+80 −80

Conversation

iisakkirotko
Copy link
Collaborator

@iisakkirotko iisakkirotko commented May 21, 2024 •
edited
Loading

Fixes #584.

Includes four breaking changes:

  • A change in the default color of the AppBar from "primary" to the Vuetify default (light/dark grey depending on theme)
  • Changes the behaviour of the navigation argument, where previously it would hide the entire AppBar it now correctly only hides the tab navigation (if present)
  • Changes the default behaviour of show_app_bar (which is now also available as an argument) to where it no longer requires the title-argument to be set for show_app_bar to be true.
  • Do not turn the first non-AppBar child of AppLayout into a sidebar element.

@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented May 21, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iisakkirotko iisakkirotko mentioned this pull request May 21, 2024
Merged
@iisakkirotko iisakkirotko marked this pull request as draft May 21, 2024 16:48
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from bd314ec to 569256e Compare May 21, 2024 17:17
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 1f72013 to 51b28c5 Compare May 22, 2024 07:41
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from 569256e to 315d628 Compare May 22, 2024 07:41
@iisakkirotko iisakkirotko added this to the Solara 2.0 milestone May 31, 2024
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 51b28c5 to c34291a Compare June 3, 2024 07:13
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from 315d628 to e0483ce Compare June 3, 2024 07:13
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from c34291a to 4ce4cf2 Compare June 3, 2024 14:44
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch 2 times, most recently from 289e509 to 569a43c Compare June 4, 2024 08:02
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 504c870 to 5b2fff1 Compare June 4, 2024 08:05
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from 569a43c to cb5426e Compare June 4, 2024 08:05
@iisakkirotko iisakkirotko mentioned this pull request Sep 18, 2024
Open
@iisakkirotko
feat!: change mutation_detection and allow_reactive_boolean defaults
6328ea7 
BREAKING CHANGE: an error is now raised if a reactive variable (not its value) is used in boolean comparisons
BREAKIGN CHANGE: mutation detection is now enabled by default
@iisakkirotko iisakkirotko marked this pull request as ready for review December 23, 2024 09:16
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from cb5426e to 565b543 Compare December 23, 2024 09:21
@iisakkirotko iisakkirotko changed the base branch from 05-21-fix_show_appbar_when_tabs_are_the_only_children to 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults December 23, 2024 09:21
This was referenced Dec 23, 2024
Merged
Draft
Merged
Merged
Merged
iisakkirotko and others added 2 commits December 23, 2024 15:01
@iisakkirotko
fix!: solara Meta and Navigator elements insert empty span into D…
3a90256 
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
@iisakkirotko
refactor!: streamline and improve applayout api
caff565
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from 565b543 to caff565 Compare December 23, 2024 14:33
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from 3a90256 to 3cdb9d4 Compare December 23, 2024 15:52
@iisakkirotko iisakkirotko mentioned this pull request Dec 23, 2024
Merged
4 tasks
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from 3cdb9d4 to 03b2dcd Compare December 27, 2024 12:56
@iisakkirotko iisakkirotko mentioned this pull request Dec 27, 2024
Merged
4 tasks
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from 03b2dcd to e925b44 Compare January 20, 2025 12:47
This was referenced Jan 20, 2025
Closed
Open
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from e925b44 to 70e86a3 Compare January 21, 2025 10:49
@iisakkirotko iisakkirotko mentioned this pull request Jan 23, 2025
Open
4 tasks
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch 3 times, most recently from a97b75b to 1d29010 Compare February 5, 2025 09:06
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from 0cef192 to 2bd9071 Compare February 7, 2025 15:19
@iisakkirotko iisakkirotko mentioned this pull request Apr 28, 2025
Closed
@iisakkirotko
Copy link
Collaborator Author

As said in #1003 (comment), this also fixes #1002.

maartenbreddels
maartenbreddels approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. PR does include some extra commits, I guess that's a graphite issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Solara 2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@iisakkirotko @maartenbreddels