Skip to content

fix[docs]: remove extra space from top of jupyter dashboard tutorial #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iisakkirotko
Copy link
Collaborator

Under the hood this was caused by #626. But since the proper solution is potentially breaking, we are saving it for Solara 2.0

Copy link
Collaborator Author

iisakkirotko commented May 1, 2024

Copy link
Collaborator Author

iisakkirotko commented May 1, 2024

Merge activity

  • May 1, 10:24 AM EDT: @iisakkirotko started a stack merge that includes this pull request via Graphite.
  • May 1, 10:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 1, 10:28 AM EDT: @iisakkirotko merged this pull request with Graphite.

@iisakkirotko iisakkirotko changed the base branch from 04-30-fix_docs_wide_outputs_of_jupyter_notebook_based_tutorials_overflowing_width_limit_ to master May 1, 2024 14:24
Under the hood this was caused by #626. But since the proper solution is potentially breaking, we are saving it for Solara 2.0
@iisakkirotko iisakkirotko force-pushed the 05-01-fix_docs_remove_extra_space_from_top_of_jupyter_dashboard_tutorial branch from c2f8fc4 to 98aa548 Compare May 1, 2024 14:27
Copy link

render bot commented May 1, 2024

@iisakkirotko iisakkirotko merged commit c1a3fef into master May 1, 2024
4 checks passed
iisakkirotko added a commit that referenced this pull request Dec 23, 2024
Reverts #627, since the workaround is no longer needed.
iisakkirotko added a commit that referenced this pull request Dec 23, 2024
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Dec 23, 2024
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Dec 27, 2024
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Jan 20, 2025
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Jan 21, 2025
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Jan 31, 2025
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Feb 4, 2025
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Feb 5, 2025
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
iisakkirotko added a commit that referenced this pull request Feb 7, 2025
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants