[Plugin] Dynamic Plugin API #105
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgorny if you check out https://github.com/wheelnext/pep_xxx_wheel_variants/tree/interactive_plugins - you can test completely the concept with I still need to fix some unittests. I'll do that later :) |
mgorny
reviewed
Jun 19, 2025
| @@ -46,19 +57,30 @@ def load_plugins(plugin_apis: list[str]) -> Generator[PluginType]: | |||
| else: | |||
| plugin_instance = plugin_callable | |||
|
|
|||
| required_attributes = PluginType.__abstractmethods__ | |||
| if isinstance(plugin_instance, PluginStaticType): | |||
There was a problem hiding this comment.
isinstance() won't work here since the protocol allows optional methods (get_build_setup). Also, I'm not sure if it's going to work with ModuleType and so on.
| "--plugin-api", | ||
| action="append", | ||
| help="Load specified plugin API", | ||
| required=True, | ||
| ) | ||
|
|
||
| parser.add_argument( |
There was a problem hiding this comment.
Just pass them via JSON. Then you won't need most of the boilerplate.
| @classmethod | ||
| def from_str(cls, input_str: str) -> Self: | ||
| # Try matching the input string with the regex pattern | ||
| match = VALIDATION_PROPERTY_REGEX.fullmatch(input_str.strip()) |
There was a problem hiding this comment.
The whole point of subprocess is to keep validation in the parent, and pass only validated data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
If you want to check this out, I advise using this branch: https://github.com/wheelnext/pep_xxx_wheel_variants/tree/interactive_plugins
Note
This PR is in draft, because I need to fix the unittests. However I tested the most basic use case and it seems to work reasonably well :)
This PR removes a significant portion of #99 in favor of a more flexible less "maintenance intensive" approach while allowing maximum freedom in plugin logic & sorting.
This PR introduces the concept of
PluginDynamicType. The olderPluginTypebecomesPluginStaticType(fully backward compatible).PluginDynamicType=> takes theVariantPropertiesof the "candidate variants" in inputsdata types:floatSemVerCalVerA :: B :: C>A :: B :: D.PluginStaticType=> take no input and rely on purestring matchingto operateWhile
PluginDynamicTypeis significantly more powerful, its implementation is significantly more delicate. And we should recommendplugin authorsto usePluginStaticTypeinterface as often as possible and rely only usePluginDynamicTypewhen absolutely necessary.Not only this PR enables to grasp fully the vast diversity of the variant ecosystem:
float/int comparison(e.g. minimum RAM requirement)It does it in a significantly more flexible, less arbitrary, more cleanly and more efficiently than PR #99.
The latter statement can be appreciated with the "fairly reduced scope" of the PR compared to #99.