Add initial variable processing #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess there will be a chicken-egg problem with whether whatwg/html#11392 or this lands first, since html-build will refuse to publish unless the "Run against whatwg/html" succeeds, and html will not let us merge a PR which fails validation. I suppose the best solution would be to land the attribute stripping/conversion functionality first, then add the variable checking afterward. I'll probably end up doing a simpler version of that by commenting out some parts of the error-on-orphaned-vars code, landing this, landing whatwg/html#11392, then landing a second PR that uncomments that check. |
This supports the work in whatwg/html#11392 with a new processor found in variables.rs, documented there. This also updates the parser to store the line numbers for each element, for use in error messages. For now this contains commented-out code to error on `<var>`s outside of `algorithm` and `var-scope` scopes, since CI will prevent us from merging a html-build change that cannot build the current main branch of whatwg/html. After the HTML PR is merged, we can uncomment that code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the work in whatwg/html#11392 with a new processor found in variables.rs, documented there.
This also updates the parser to store the line numbers for each element, for use in error messages.
For now this contains commented-out code to error on
<var>s outside ofalgorithmandvar-scopescopes, since CI will prevent us from merging a html-build change that cannot build the current main branch of whatwg/html. After the HTML PR is merged, we can uncomment that code.@jmdyck you may not want to review all the code, but the tests at the bottom of
variables.rsmight be worthwhile checking over.