Skip to content

Conversation

paulobernardoaf
Copy link
Contributor

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.52%. Comparing base (56ceaf6) to head (8fad1d6).

Files with missing lines Patch % Lines
src/components/SystemIntegrations.vue 84.61% 16 Missing ⚠️
src/app.vue 0.00% 5 Missing ⚠️
src/composables/useModuleUpdateRoute.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
+ Coverage   49.34%   49.52%   +0.17%     
==========================================
  Files         184      185       +1     
  Lines       21429    21544     +115     
  Branches      602      618      +16     
==========================================
+ Hits        10575    10669      +94     
- Misses      10854    10875      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aldemylla Aldemylla force-pushed the feat/insights-module-federation branch from 04cf03e to b1e8d5d Compare July 1, 2025 13:54
Base automatically changed from feat/insights-module-federation to main July 28, 2025 21:30
…nd loading state

- Removed iframe fallback logic and integrated LoadingModule for better loading state management.
- Introduced useModuleUpdateRoute composable for dynamic route handling.
- Added unit tests for SystemIntegrations component to cover mounting, unmounting, and rendering conditions.
- Updated the condition in handleUpdateRoute to check for undefined path before checking for routeName inclusion, ensuring robust route handling.
- Updated the handleUpdateRoute function to directly check if the current route path includes the specified routeName, improving clarity and efficiency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants