-
Notifications
You must be signed in to change notification settings - Fork 3
Dialog component and ModalDialog redesign #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aldemylla
wants to merge
12
commits into
main
Choose a base branch
from
feature/dialog-redesign
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,319
−411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dialog components
…data-testid attributes
…tes and enhance size handling
…alue and update tests accordingly
…/dialog-redesign
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 34.06% 33.26% -0.80%
==========================================
Files 153 160 +7
Lines 3714 3755 +41
Branches 1067 1069 +2
==========================================
- Hits 1265 1249 -16
- Misses 2449 2506 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Motivation and Context
The unnnic design system needed a modern Dialog component to replace the legacy ModalDialog implementation. The new Dialog component provides better accessibility, a more flexible API, and improved developer experience.
Unlike the legacy ModalDialog, the new Dialog components follow a composable pattern that allows developers to build custom dialog layouts while maintaining consistency and accessibility through reka-ui primitives.
Summary of Changes
New Components Added:
Dialog- Main wrapper component with controlled/uncontrolled open stateDialogContent- Content container with overlay, animations and size variantsDialogHeader- Header section with optional close button and type-based iconsDialogTitle- Accessible title componentDialogFooter- Footer section with optional dividerDialogClose- Trigger component to close the dialogDialogTrigger- Trigger component to open the dialogImplementation Details:
v-model:openfor programmatic controlRefactoring:
ModalDialogcomponent to use new Dialog components internallyModalDialogas deprecated (to be discontinued)parentClassprop toDialogContentfor temporary backward compatibilityUsage Example:
Design Files
Demonstration