feat: weka-api aws lambda #308

rugggger · 2024-12-01T10:48:08Z

https://wekaio.atlassian.net/browse/CLOUD-2804

WIP

assafgi · 2024-12-03T14:43:50Z

lambdas.tf

@@ -61,6 +61,7 @@ resource "aws_lambda_function" "deploy_lambda" {
      REPORT_LAMBDA_NAME                = aws_lambda_function.report_lambda.function_name
      FETCH_LAMBDA_NAME                 = aws_lambda_function.fetch_lambda.function_name
      STATUS_LAMBDA_NAME                = aws_lambda_function.status_lambda.function_name
+      WEKA_API_LAMBDA_NAME              = aws_lambda_function.weka_api_lambda.function_name


not needed here

assafgi · 2024-12-03T14:44:51Z

protocol_gateways.tf

@@ -31,6 +31,7 @@ module "smb_protocol_gateways" {
  report_lambda_name                  = aws_lambda_function.report_lambda.function_name
  fetch_lambda_name                   = aws_lambda_function.fetch_lambda.function_name
  status_lambda_name                  = aws_lambda_function.status_lambda.function_name
+  weka_api_lambda_name                = aws_lambda_function.weka_api_lambda.function_name


not needed here

assafgi · 2024-12-03T14:44:55Z

protocol_gateways.tf

@@ -69,6 +70,7 @@ module "s3_protocol_gateways" {
  report_lambda_name                  = aws_lambda_function.report_lambda.function_name
  fetch_lambda_name                   = aws_lambda_function.fetch_lambda.function_name
  status_lambda_name                  = aws_lambda_function.status_lambda.function_name
+  weka_api_lambda_name                = aws_lambda_function.weka_api_lambda.function_name


not needed here

assafgi · 2024-12-03T14:44:59Z

protocol_gateways.tf

@@ -107,6 +109,7 @@ module "nfs_protocol_gateways" {
  report_lambda_name                  = aws_lambda_function.report_lambda.function_name
  fetch_lambda_name                   = aws_lambda_function.fetch_lambda.function_name
  status_lambda_name                  = aws_lambda_function.status_lambda.function_name
+  weka_api_lambda_name                = aws_lambda_function.weka_api_lambda.function_name


not needed here

assafgi · 2024-12-03T14:45:12Z

modules/protocol_gateways/iam.tf

@@ -95,6 +95,7 @@ resource "aws_iam_policy" "invoke_lambda_function" {
          "arn:aws:lambda:*:*:function:${var.report_lambda_name}*",
          "arn:aws:lambda:*:*:function:${var.fetch_lambda_name}*",
          "arn:aws:lambda:*:*:function:${var.status_lambda_name}*",
+          "arn:aws:lambda:*:*:function:${var.weka_api_lambda_name}*",


not needed here

assafgi · 2024-12-03T14:49:22Z

lambdas/main.go

@@ -439,6 +440,10 @@ func managementHandler(ctx context.Context, req management.ManagementRequest) (p
 	}
 }

+func wekaApiHandler(ctx context.Context, req weka_api.WekaApiRequest) (*weka_api.WekaApiResponse, error) {
+	return weka_api.MakeWekaApiRequest(ctx, req)


this code isn't doing anything

assafgi · 2024-12-04T13:50:04Z

lambdas.tf

+  environment {
+    variables = {
+      LAMBDA                     = "weka-api"
+      STATE_TABLE                = local.dynamodb_table_name


need to remove the unused env vars

assafgi · 2024-12-04T13:51:06Z

lambdas/functions/management/management.go

+// the payload for that specific operation.
+//
+// At this time, the only operation supported is "status"
+type ManagementRequest struct {


this struct can be removed, we should only use WekaApiRequest and do the required updates to the current status implementation

assafgi · 2025-01-07T07:37:24Z

lambdas/functions/weka_api/weka_api.go

+	return r, nil
+}
+
+func invokeManagementLambda[T any](ctx context.Context, wr *management.WekaApiRequest) (response *T, err error) {


Why not just interface?

rugggger requested a review from assafgi December 1, 2024 10:48

rugggger had a problem deploying to default December 1, 2024 10:48 — with GitHub Actions Failure

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 65b2b6d to c59648f Compare December 1, 2024 15:57

rugggger temporarily deployed to default December 1, 2024 15:57 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 468f910 to fed0539 Compare December 1, 2024 16:43

rugggger temporarily deployed to default December 1, 2024 16:43 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from d77e1a6 to a4fc05c Compare December 2, 2024 09:13

rugggger temporarily deployed to default December 2, 2024 09:13 — with GitHub Actions Inactive

assafgi reviewed Dec 3, 2024

View reviewed changes

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 3d18788 to 181e9f6 Compare December 4, 2024 07:50

rugggger temporarily deployed to default December 4, 2024 07:50 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 2a40191 to 798b93f Compare December 4, 2024 07:59

rugggger temporarily deployed to default December 4, 2024 07:59 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 778871d to 4c86c72 Compare December 4, 2024 08:07

rugggger temporarily deployed to default December 4, 2024 08:07 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 0332608 to 4facc95 Compare December 4, 2024 09:04

rugggger temporarily deployed to default December 4, 2024 09:05 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 81658d7 to 1e040ff Compare December 4, 2024 09:35

rugggger temporarily deployed to default December 4, 2024 09:35 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 4b922fa to 77ec9eb Compare December 4, 2024 10:13

rugggger temporarily deployed to default December 4, 2024 10:13 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 15b77ef to b703fa3 Compare December 4, 2024 12:58

rugggger temporarily deployed to default December 4, 2024 12:59 — with GitHub Actions Inactive

rugggger requested a review from assafgi December 4, 2024 13:03

assafgi reviewed Dec 4, 2024

View reviewed changes

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 286425c to 494e9f8 Compare December 4, 2024 14:01

rugggger had a problem deploying to default December 4, 2024 14:01 — with GitHub Actions Failure

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 626d829 to 3396d96 Compare December 4, 2024 14:05

rugggger temporarily deployed to default December 4, 2024 14:05 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 4e626f2 to cfd2af6 Compare December 5, 2024 07:47

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 0f43fc8 to aa613d8 Compare December 19, 2024 10:26

rugggger temporarily deployed to default December 19, 2024 10:27 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 387ef9c to ad2fe5a Compare December 19, 2024 10:44

rugggger temporarily deployed to default December 19, 2024 10:44 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from e39d1b4 to ad2fe5a Compare December 19, 2024 10:47

rugggger temporarily deployed to default December 19, 2024 10:47 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 84cb188 to 08217c6 Compare December 22, 2024 11:21

rugggger temporarily deployed to default December 22, 2024 11:21 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 4b5cdfb to f4942cf Compare December 22, 2024 11:22

rugggger temporarily deployed to default December 22, 2024 11:22 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 5678484 to a4f64c5 Compare December 23, 2024 09:20

rugggger temporarily deployed to default December 23, 2024 09:20 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 3a38edb to 01ec80a Compare January 6, 2025 12:48

rugggger temporarily deployed to default January 6, 2025 12:48 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 8885e6b to 01ec80a Compare January 6, 2025 12:59

rugggger temporarily deployed to default January 6, 2025 12:59 — with GitHub Actions Inactive

assafgi reviewed Jan 7, 2025

View reviewed changes

assafgi approved these changes Jan 7, 2025

View reviewed changes

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 3733e81 to cafc845 Compare January 7, 2025 08:19

rugggger temporarily deployed to default January 7, 2025 08:19 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 2c0ff3d to 74b5c02 Compare January 7, 2025 08:22

rugggger temporarily deployed to default January 7, 2025 08:22 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from ed3d98c to 392326a Compare January 7, 2025 08:28

rugggger temporarily deployed to default January 7, 2025 08:28 — with GitHub Actions Inactive

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 7e0bff5 to 976d571 Compare January 7, 2025 08:32

rugggger temporarily deployed to default January 7, 2025 08:32 — with GitHub Actions Inactive

rugggger temporarily deployed to default January 7, 2025 08:52 — with GitHub Actions Inactive

feat: add weka_api function

f44f34e

rugggger force-pushed the CLOUD-2804/weka-api-lambda branch from 221caf0 to f44f34e Compare January 7, 2025 08:59

rugggger temporarily deployed to default January 7, 2025 08:59 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: weka-api aws lambda #308

feat: weka-api aws lambda #308

Uh oh!

rugggger commented Dec 1, 2024

Uh oh!

assafgi Dec 3, 2024

Uh oh!

assafgi Dec 3, 2024

Uh oh!

assafgi Dec 3, 2024

Uh oh!

assafgi Dec 3, 2024

Uh oh!

assafgi Dec 3, 2024

Uh oh!

assafgi Dec 3, 2024

Uh oh!

assafgi Dec 4, 2024

Uh oh!

assafgi Dec 4, 2024

Uh oh!

assafgi Jan 7, 2025

Uh oh!

Uh oh!

feat: weka-api aws lambda #308

Are you sure you want to change the base?

feat: weka-api aws lambda #308

Uh oh!

Conversation

rugggger commented Dec 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!