Skip to content

Add control over including schemas for structured output #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Jun 13, 2025

And note that by default, the implementation may do so.

Closes #125.

@cduvall to review.


Preview | Diff

And note that by default, the implementation may do so.

Closes #125.
@sushraja-msft
Copy link
Contributor

LGTM, the property name omitResponseConstraintInput - is includeResponseContraintInPrompt more intuitive name?

Copy link

@clarkduvall clarkduvall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@domenic
Copy link
Collaborator Author

domenic commented Jun 16, 2025

LGTM, the property name omitResponseConstraintInput - is includeResponseContraintInPrompt more intuitive name?

We want to be sure that the default value is false, per Web IDL's guidance. So that's why we go with "omit" instead of "include".

We could do "FromPrompt" instead of "Input", but I'm trying to keep it at least a little bit shorter, so I'll stick with "Input" for now...

@domenic domenic merged commit 9df9109 into main Jun 16, 2025
2 checks passed
@domenic domenic deleted the more-schema branch June 16, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to control JSON schema token usage
3 participants