Add: Lending category

[ch0rizo]

Description

Added categories for lendingObjects, so that we call filter on categories👍

I am unsure which categories that are relevant... Please come with some suggestions😄

Testing

• The code quality is at a minimum required level of quality, readability, and performance.
• I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Resolves ABA-1557

[linear]

ABA-1557 Add: Categories on lending objects

[jonasdeluna]

Could the categories be dynamic instead? I feel like this might make more sense so we dont have to update this every time a new potentially non-categorizable object is added. Like with tags, you can search and if the category doesnt exist you can make it yourself.

[ch0rizo]

Could the categories be dynamic instead? I feel like this might make more sense so we dont have to update this every time a new potentially non-categorizable object is added. Like with tags, you can search and if the category doesnt exist you can make it yourself.

I have thought about this, and do see how a dynamic solution would be more flexible. At the same time I dont think new categories on a lending object will be a frequent occurance. I also added a "Other" category if its a niche category or does not fit the mentioned. Still, I am not sure about how relevant the current categories are...

[itsisak]

I have thought about this, and do see how a dynamic solution would be more flexible. At the same time I dont think new categories on a lending object will be a frequent occurance. I also added a "Other" category if its a niche category or does not fit the mentioned. Still, I am not sure about how relevant the current categories are...

I agree on that it is not necessary to add. Another point is that if it is too accessible to make categories it could lead to too many categories which would kind of defeat the purpose and for frontend design purposes it is also nice to limit this amount.

[itsisak]

I agree on that it is not necessary to add. Another point is that if it is too accessible to make categories it could lead to too many categories which would kind of defeat the purpose and for frontend design purposes it is also nice to limit this amount.

Although I imagine these categories will have to be updated at some point when the system is being used more actively to better represent the items that exist. Hard to predict which categories is best at this point.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.39%. Comparing base (7801052) to head (cc8ca8f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
+ Coverage   82.37%   82.39%   +0.01%     
==========================================
  Files         355      355              
  Lines       12542    12550       +8     
==========================================
+ Hits        10332    10340       +8     
  Misses       2210     2210              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[falbru]

Looks good! We probably need to change the categories later as Isak said