Redesign poll component #4481
Merged
Redesign poll component #4481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
reviewed
Feb 22, 2024
| background-color: var(--lego-red-color); | ||
| color: var(--lego-card-color); | ||
| padding: 0 0.5rem 0.5rem; | ||
| box-shadow: 0 2px 2px rgba(0, 0, 0, 20%); |
There was a problem hiding this comment.
Suggested change
| box-shadow: 0 2px 2px rgba(0, 0, 0, 20%); | |
| box-shadow: var(--shadow-sm); |
Not sure which you want
There was a problem hiding this comment.
Not too sure about this one - all the shadows in variables have either very low opacity or are very spread out, so might have to define some new ones
| color: var(--success-color); | ||
| .arrowIcon { | ||
| color: var(--lego-card-color); | ||
| text-shadow: 0 2px 2px rgba(0, 0, 0, 20%); |
There was a problem hiding this comment.
Suggested change
| text-shadow: 0 2px 2px rgba(0, 0, 0, 20%); | |
| text-shadow: var(--shadow-md); |
Or a different one (most likely)
norbye
force-pushed
the
poll-redesign
branch
from
6d6556d to
9336b66
Compare
norbye
force-pushed
the
poll-redesign
branch
3 times, most recently
from
2be2dc8 to
ceb9056
Compare
norbye
force-pushed
the
poll-redesign
branch
2 times, most recently
from
1c7a7a6 to
83b731a
Compare
Co-authored-by: PeterJFB <[email protected]>
norbye
force-pushed
the
poll-redesign
branch
from
83b731a to
f574687
Compare
norbye
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shame to see updated components go to waste because of inactivity, so I have started scavenging what I could from #2707 and updating it ever so slightly to merge it to master:)
With this update, no poll options are displayed until it is triggered, so the issue of showing all options while the component loads is no longer an issue.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Caution
Make sure your images do not contain any real user information.
Before - smol
Skjermopptak.2024-02-25.kl.12.37.39.mov
After - smol
Skjermopptak.2024-02-25.kl.12.25.39.mov
Before - chunky
Skjermopptak.2024-02-25.kl.12.36.52.mov
After - chunky
Skjermopptak.2024-02-25.kl.12.35.34.mov
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-849, ABA-537, ABA-769