Improves Render speed of Zoom tiles by using "free" capacity of the Render Threads. #4013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ender Threads. Works by checking the amount of active Threads processing tiles. If the amount of Active Threads is less than parallelrendercnt we can use the "spare" capacity for zoom processing. We are using a seperate ThreadPoolExecutor to achive this. Also adds one more cancellation check to process cancellations for large zoom out renders (when many tiles needs to be processed)
|
Looks promising - will review this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works by checking the amount of active Threads processing tiles. If the amount of Active Threads is less than parallelrendercnt we can use the "spare" capacity for zoom processing. We are using a seperate ThreadPoolExecutor to achive this. Also adds one more cancellation check to process cancellations for large zoom out renders (when many tiles needs to be processed). Additionally it will report Zoom Rendering progress.
Just some metrics for better perspective.
This change improves Total render time (Start of fullrender until zoom out rendering is completed) by 22-23%
The only drawback is that under high load situations the avg tile render speed can drop.
In Terms of usability Results the Zoom Renderer will complete faster thus providing potentially better user experience. Overall with the improvements from #4011 we are still a bit faster in overall render speed compared to before.