Skip to content

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 9, 2025

This is a reland of commit 7ccda24096f5914472cbf01e76632bd09641b8cd

This reland fixes unexpected ULP distance for subgraph gatherElements +
matmul.

Original change's description:

webnn: Enable mxbai_rerank_base_v1_fp32 model on TFLite backend

GatherElements is emulated by GatherND that will always output a tensor
with one dimension because the shape of the indices tensor is 2
[flat_indices_size, input_rank], so we need to reshape the output tensor
to the expected shape.

For example, if the input shape is [4, 2, 2], the indices are [1, 2, 2]
and axis = 0, then the output shape of gatherND will be [4] that is
calculated with ResizeTensor. The shape needs to be reshaped to [1, 2,
2].

Bug: 446463978
Change-Id: If3cbada6a46822ec4b44b60dec831caa4bc174f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6987334
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Junwei Fu <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1527269}

Bug: 446463978
Change-Id: Ie869a41370ba068454b231d0b9a0e9503783dbb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7024653
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Junwei Fu <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1527909}

This is a reland of commit 7ccda24096f5914472cbf01e76632bd09641b8cd

This reland fixes unexpected ULP distance for subgraph gatherElements +
matmul.

Original change's description:
> webnn: Enable mxbai_rerank_base_v1_fp32 model on TFLite backend
>
> GatherElements is emulated by GatherND that will always output a tensor
> with one dimension because the shape of the indices tensor is 2
> [flat_indices_size, input_rank], so we need to reshape the output tensor
> to the expected shape.
>
> For example, if the input shape is [4, 2, 2], the indices are [1, 2, 2]
> and axis = 0, then the output shape of gatherND will be [4] that is
> calculated with ResizeTensor. The shape needs to be reshaped to [1, 2,
> 2].
>
> Bug: 446463978
> Change-Id: If3cbada6a46822ec4b44b60dec831caa4bc174f0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6987334
> Reviewed-by: Reilly Grant <[email protected]>
> Commit-Queue: Junwei Fu <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1527269}

Bug: 446463978
Change-Id: Ie869a41370ba068454b231d0b9a0e9503783dbb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7024653
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Junwei Fu <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1527909}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants