-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[testdriver] Add testdriver extension for prefetch event in speculation module #55274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[testdriver] Add testdriver extension for prefetch event in speculation module #55274
Conversation
…t and infrastructure tests
…b.com/srwei/wpt into SpeculationRulesPrefetchWebDriverBidi
Please add wdspec tests as well. Actually, I'd prefer to have wdspec tests first in a separate PR, but it's up to you. |
infrastructure/testdriver/bidi/speculation/prefetch_status_updated.https.html
Outdated
Show resolved
Hide resolved
infrastructure/testdriver/bidi/speculation/prefetch_status_updated.https.html
Outdated
Show resolved
Hide resolved
Oh I thought webdriver/tests/bidi/external/speculation/prefetch_status_updated/ tests were the wdpsec tests |
infrastructure/testdriver/bidi/speculation/prefetch_status_updated.https.html
Show resolved
Hide resolved
webdriver/tests/bidi/external/speculation/prefetch_status_updated/invalid.py
Outdated
Show resolved
Hide resolved
My bad, I missed it. Sure. |
webdriver/tests/bidi/external/speculation/prefetch_status_updated/prefetch_status_updated.py
Show resolved
Hide resolved
webdriver/tests/bidi/external/speculation/prefetch_status_updated/prefetch_status_updated.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/external/speculation/prefetch_status_updated/prefetch_status_updated.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/external/speculation/prefetch_status_updated/prefetch_status_updated.py
Outdated
Show resolved
Hide resolved
window.test_driver_internal.bidi.speculation.prefetch_status_updated.subscribe = | ||
function(params) { | ||
return subscribe( | ||
{...params, events: ['speculation.prefetchStatusUpdated'], contexts: null}); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm. BTW why do you need the global subscription? The events are emitted to the specific browsing context, so you could safely target them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially was seeing how it would fit with the existing speculation rules prefetch wpt tests, but I was able to confirm we can utilize the new spawned window when subscribing to the event. I have changed it back to the normal browsing context subscription.
Spec: https://wicg.github.io/nav-speculation/prefetch.html#automated-testing
chromium-bidi implementation: GoogleChromeLabs/chromium-bidi@66d3585
Adding testdriver extension for the speculation module that is mainly to add the prefetch_status_updated event. No commands.
This event will replace the current timeout mechanism for speculation rules prefetch in the wpt prefetch corpus: https://github.com/web-platform-tests/wpt/tree/master/speculation-rules/prefetch
Follow up CLs will be raised to update the above tests to use the new event handling.
@sadym-chromium would you be able to help with rollover for chromium-bidi implementation?