Honor column-height more strictly. #55259
Draft
+439
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolution here: w3c/csswg-drafts#11976 (comment) Don't let spanners disturb the row rhythm, but instead let them consume from the available row height. Move them to the next row if they don't fit, and there is already content in the row. Let them overflow subsequent rows if they are too tall to fit a full row. Introduce a `%` (modulo) operator to LayoutUnit for this task. Always make a row as tall as specified. Don't let column balancing or forced breaks shorten it. This new behavior means that we may need to insert a row gap (with rules, if requested) before a spanner, so do this. Update the gap geometry code to tolerate this. It assumed that only spanner-end gaps might lack column gaps, but this may now also be the case between a regular row gap and spanner-start. multicol-gap-decorations-007.html is now failing, and it doesn't make sense, at this time, to change it so that it passes, since it hasn't been decided how rows should fragment (within an outer fragmentation context) yet. Mark it as failing. Bug: 403183884, 440040889 Change-Id: I9002154661db2956030092b97594b6112fb87d76
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7008371
branch
from
6682a57 to
bf70f50
Compare
|
The wpt-firefox-nightly-stability failure ought to be fixed by 54070c7. Any update to the CL (or just landing it) should push an update to this PR, which probably includes a rebase. But if not we can admin merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution here:
w3c/csswg-drafts#11976 (comment)
Don't let spanners disturb the row rhythm, but instead let them consume
from the available row height. Move them to the next row if they don't
fit, and there is already content in the row. Let them overflow
subsequent rows if they are too tall to fit a full row.
Introduce a
%(modulo) operator to LayoutUnit for this task.Always make a row as tall as specified. Don't let column balancing or
forced breaks shorten it.
This new behavior means that we may need to insert a row gap (with
rules, if requested) before a spanner, so do this. Update the gap
geometry code to tolerate this. It assumed that only spanner-end gaps
might lack column gaps, but this may now also be the case between a
regular row gap and spanner-start.
multicol-gap-decorations-007.html is now failing, and it doesn't make
sense, at this time, to change it so that it passes, since it hasn't
been decided how rows should fragment (within an outer fragmentation
context) yet. Mark it as failing.
Bug: 403183884, 440040889
Change-Id: I9002154661db2956030092b97594b6112fb87d76
Reviewed-on: https://chromium-review.googlesource.com/7008371
WPT-Export-Revision: 8e5e832cb8c1e9dc0934e3797f3f97bb22bb813e