Anchor: Update anchor-scroll-position-try-011.html to scroll more. #55256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates anchor-scroll-position-try-011.html to use scrollWidth and scrollHeight for scrolling to force different fallback selection. Previously, we would prefer to use last remembered offsets which wouldn't change things until we intersect the containing block. [email protected] Bug: 438515315 Change-Id: I63626c8dbaa68065840a4c2994e2e046c3612acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7012327 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1525759}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7012327
branch
from
76ec2c9 to
6637b65
Compare
wpt-pr-bot
approved these changes
Oct 6, 2025
|
Fully passes on Safari now (STP 229 and tip of tree), so looks good to me. Thank you for fixing this 🙏 |
nt1m
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates anchor-scroll-position-try-011.html to use
scrollWidth and scrollHeight for scrolling to force different fallback
selection. Previously, we would prefer to use last remembered offsets
which wouldn't change things until we intersect the containing block.
R=[email protected]
Bug: 438515315
Change-Id: I63626c8dbaa68065840a4c2994e2e046c3612acb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7012327
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1525759}