Skip to content

perf: base line #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

perf: base line #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
452c68d
perf: base line
stormslowly Nov 17, 2025
2b5ef1e
refactor: sync bench code
stormslowly Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions benches/resolver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use std::{
};

use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
use rspack_resolver::{ResolveOptions, Resolver};
use serde_json::Value;
use tokio::{
runtime::{self, Builder},
Expand Down Expand Up @@ -91,6 +92,33 @@ fn rspack_resolver() -> rspack_resolver::Resolver {
})
}

fn resolver_with_many_extensions() -> rspack_resolver::Resolver {
Resolver::new(ResolveOptions {
extensions: vec![
".bad0".to_string(),
".bad1".to_string(),
".bad2".to_string(),
".bad3".to_string(),
".bad4".to_string(),
".bad5".to_string(),
".bad6".to_string(),
".bad7".to_string(),
".bad8".to_string(),
".bad9".to_string(),
".mtsx".to_string(),
".mts".to_string(),
".mjs".to_string(),
".tsx".to_string(),
".ts".to_string(),
".jsx".to_string(),
".js".to_string(),
],
imports_fields: vec![],
exports_fields: vec![],
..Default::default()
})
}

fn create_async_resolve_task(
rspack_resolver: Arc<rspack_resolver::Resolver>,
path: PathBuf,
Expand Down Expand Up @@ -183,6 +211,30 @@ fn bench_resolver(c: &mut Criterion) {
},
);

group.bench_with_input(
BenchmarkId::from_parameter("[single-threaded]resolve with many extensions"),
&data,
|b, data| {
let runner = runtime::Builder::new_current_thread()
.build()
.expect("failed to create tokio runtime");
let rspack_resolver = resolver_with_many_extensions();

b.to_async(runner).iter_with_setup(
|| {
rspack_resolver.clear_cache();
},
|_| async {
for (path, request) in data {
_ = rspack_resolver
.resolve(path, &format!("{}/bad", request))
.await;
}
},
);
},
);

group.bench_with_input(
BenchmarkId::from_parameter("multi-thread"),
&data,
Expand Down
Loading