-
Notifications
You must be signed in to change notification settings - Fork 7
NFC-47 NFC support for web-eid example #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SanderKondratjevNortal
wants to merge
21
commits into
web-eid-mobile
Choose a base branch
from
NFC-47
base: web-eid-mobile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…n. Replace VALID_NFC_AUTH_TOKEN with VALID_WEB_EID_1_1AUTH_TOKEN. Return html with spring security filter.
…quest if statement. Remove doFilter method. Fix request matchers. Inline filterchain. Remove welcome page from permit all.
…filters; remove ChallengeController
102c405
to
5108d00
Compare
…ax for mobile auth flow
…WebEidChallengeNonceFilter to post. Index js method to POST with csrf. Remove @secured and @EnableMethodSecurity. Remove WebMvcConfigurer and view controllers from ApplicationConfiguration. Return auth_uri as JSON map. Constant name to OBJECT_MAPPER. Remove unnecessary shouldNotFilterAsyncDispatch override. Inline CSRF token and header directly in login page script. Show mobileAuthError message on login page.
…. Remove unnecessary permitAll matchers for filter-handled auth endpoints. Unify filter registration. Remove cookieFlagsInitializer. Format isMobileDevice block for readability. Rename matcher to requestMatcher in filters for consistency and clarity. Remove unnecessary WebAuthenticationDetails from token in login filter. Remove redundant ChallengeNonceStore from WebEidMobileAuthInitFilter. Fix tests. Use signing cert for ObjectMother.
…esponse.java. Remove unnecessary /error permitAll. Rename JSON constant to OBJECT_WRITER and other strings to constant. Inline ChallengeDTO.
…x CSRF header and token order in login page HTML template. Use records AuthPayload and AuthUri instead of Map.of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sander Kondratjev [email protected]